gergo/applicationIdAttach #391
Open
+17
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdbroughton
reviewed
Mar 1, 2025
| @@ -332,7 +332,7 @@ def _mark_run( | |||
| def attach_error_to_objects( | |||
| self, | |||
| category: str, | |||
| object_ids: Union[str, List[str]], | |||
| objects: Union[Base, List[Base]], | |||
There was a problem hiding this comment.
If we are changing this anyway, I think requiring a List[Base] only is preferable to either a single or a list
| raise ValueError( | ||
| f"Need atleast one object_id to report a(n) {level.value.upper()}" | ||
| ) | ||
| id_list = object_ids | ||
| id_list = [o.id for o in objects] |
There was a problem hiding this comment.
im not a fan of this - partly because we are storing a list of objects as result data contextual to the objects - ids worked well here as there wasn't an inference the developer could make that this could be NEW Base objects.
We don't serialize these objects in the same way as a Send, do we???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds application ids to the result metadata